BDMS 389: open and datalogger suitability status implementation for well inventory csv#306
Merged
Merged
Conversation
…d add_thing These fields now go into the StatusHistory table, not as fields in the Thing table
jacob-a-brown
requested review from
TylerAdamMartinez,
chasetmartin,
jirhiker and
ksmuczynski
jacob-a-brown
changed the title
Contributor
Author
|
@chasetmartin I fixed the merge conflict artifact with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
status_historytable:is_openanddatalogger_possibleHow
Implementation summary - the following was changed / added / removed:
status_historytableNotes
Any special considerations, workarounds, or follow-up work to note?
well-inventory-csvcontains the work done in PR BDMS 389 inspired: status history refactor for wells #299. This was approved to go intostaging, but since it modifies the database models it has not yet been merged. Once that is merged intostagingthe refactoring of putting these fields into thestatus_historytable will be in bothstagingandwell-inventory-csvwell-inventory-csvall well core and additional information will be accounted for. Next is the water levels